remove ineffective cache mount lines - #3840
Open
EmilyRagan wants to merge 1 commit into
Open
EmilyRagan wants to merge 1 commit into
EmilyRagan wants to merge 1 commit into
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3840 +/- ##
==========================================
+ Coverage 79.38% 79.40% +0.01%
==========================================
Files 897 897
Lines 67605 67614 +9
Branches 2658 2610 -48
==========================================
+ Hits 53666 53686 +20
+ Misses 13266 13259 -7
+ Partials 673 669 -4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
EmilyRagan
added this pull request to stack #3842
September 8, 2026 23:46
EmilyRagan
removed this pull request from stack #3842
September 15, 2026 00:09
EmilyRagan
marked this pull request as ready for review
September 15, 2026 00:10
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Removed Docker cache mounts for uv
Why it changed
They were being overridden by UV_CACHE_DIR already, cache mounts were misleading
Testing strategy
openc3.sh buildReview notes
SonarQube failures are existing reports of missing
--no-buildflags. I am looking into possible ways to address this, will open a separate PR